[16.0][FIX] connector_lighting_sapb1: convert ibox_volume per SAP SVolUnit#98
Open
[16.0][FIX] connector_lighting_sapb1: convert ibox_volume per SAP SVolUnit#98
Conversation
The previous code multiplied SVolume by 1000 unconditionally, assuming all products use dm³ (SVolUnit=3). SAP B1 stores volumes in three different units (dm³, cm³, m³), producing 1000× inflated values for the non-dm³ products. SVolUnit is now read from SAP, included in the row hash so existing products are re-imported, and used to pick the correct multiplier into cm³ (the unit of lighting.product.ibox_volume).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #98 +/- ##
==========================================
- Coverage 43.60% 43.55% -0.06%
==========================================
Files 283 283
Lines 8104 8132 +28
Branches 1564 1571 +7
==========================================
+ Hits 3534 3542 +8
- Misses 4475 4495 +20
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code multiplied SVolume by 1000 unconditionally, assuming all products use dm³ (SVolUnit=3). SAP B1 stores volumes in three different units (dm³, cm³, m³), producing 1000× inflated values for the non-dm³ products. SVolUnit is now read from SAP, included in the row hash so existing products are re-imported, and used to pick the correct multiplier into cm³ (the unit of lighting.product.ibox_volume).